-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: build sessPool even if RunWorker == false (#33677) #33698
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@wjhuang2016 you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f297962920d413242e3cfa4c61548e6bf3cdfe83 |
closed for DMR version |
cherry-pick #33677 to release-6.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33698
After apply modifications, you can push your change to this PR via:
Signed-off-by: wjhuang2016 [email protected]
What problem does this PR solve?
Issue Number: close #33676
Problem Summary:
struct ddl doesn't have sessPool if RunWorker == false
What is changed and how it works?
Move the code to make sure build sessPool even if RunWorker == false
Check List
Tests
pass integration-ddl-test
Side effects
Documentation
Release note